From a131e17a6e35e5f83192494ae0aa5e6349fdb790 Mon Sep 17 00:00:00 2001 From: Andreas Schultz Date: Wed, 27 Jul 2016 12:17:00 +0200 Subject: [PATCH] fix 802.11 Station Key IE handling memsetting the data to zero right after assigning them is obviously wrong --- src/common/capwap_element_80211_stationkey.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/common/capwap_element_80211_stationkey.c b/src/common/capwap_element_80211_stationkey.c index 85e1a47..af5d165 100644 --- a/src/common/capwap_element_80211_stationkey.c +++ b/src/common/capwap_element_80211_stationkey.c @@ -39,7 +39,9 @@ static void capwap_80211_stationkey_element_create(void* data, capwap_message_el } /* */ -static void* capwap_80211_stationkey_element_parsing(capwap_message_elements_handle handle, struct capwap_read_message_elements_ops* func) { +static void* capwap_80211_stationkey_element_parsing(capwap_message_elements_handle handle, + struct capwap_read_message_elements_ops* func) +{ unsigned short length; struct capwap_80211_stationkey_element* data; @@ -53,10 +55,11 @@ static void* capwap_80211_stationkey_element_parsing(capwap_message_elements_han } /* */ - data = (struct capwap_80211_stationkey_element*)capwap_alloc(sizeof(struct capwap_80211_stationkey_element)); + data = (struct capwap_80211_stationkey_element *) + capwap_alloc(sizeof(struct capwap_80211_stationkey_element)); + memset(data, 0, sizeof(struct capwap_80211_stationkey_element)); data->keylength = length - 20; data->key = (uint8_t*)capwap_alloc(data->keylength); - memset(data, 0, sizeof(struct capwap_80211_stationkey_element)); /* Retrieve data */ func->read_block(handle, data->address, MACADDRESS_EUI48_LENGTH);