7u83/freewtp
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

If there is no DNS available on system start the capwap-wtp will stop while evaluating the configuration. I fixed that by checking if the address was yet translated on every address access. If not a DNS request is started before continuing.

Browse Source
This commit is contained in:
Moritz Rosenthal 2016-03-24 07:09:29 +01:00
parent 1d95a62061
commit 7b9f515bd7
4 changed files with 90 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/common/capwap_network.h
View File

@ -11,6 +11,7 @@
/* */ /* */
#define CAPWAP_MACADDRESS_EUI48_BUFFER 18 #define CAPWAP_MACADDRESS_EUI48_BUFFER 18
#define CAPWAP_MACADDRESS_EUI64_BUFFER 24 #define CAPWAP_MACADDRESS_EUI64_BUFFER 24
#define CAPWAP_MAX_FQDN_SIZE 128
/* */ /* */
union sockaddr_capwap { union sockaddr_capwap {
@ -20,6 +21,12 @@ union sockaddr_capwap {
struct sockaddr_storage ss; struct sockaddr_storage ss;
}; };
struct addr_capwap {
char fqdn[CAPWAP_MAX_FQDN_SIZE];
union sockaddr_capwap socket;
char resolved;
};
/* Helper */ /* Helper */
#define CAPWAP_GET_NETWORK_PORT(addr) ntohs((((addr)->ss.ss_family == AF_INET) ? (addr)->sin.sin_port : (((addr)->ss.ss_family == AF_INET6) ? (addr)->sin6.sin6_port : 0))) #define CAPWAP_GET_NETWORK_PORT(addr) ntohs((((addr)->ss.ss_family == AF_INET) ? (addr)->sin.sin_port : (((addr)->ss.ss_family == AF_INET6) ? (addr)->sin6.sin6_port : 0)))
#define CAPWAP_SET_NETWORK_PORT(addr, port) if ((addr)->ss.ss_family == AF_INET) { \ #define CAPWAP_SET_NETWORK_PORT(addr, port) if ((addr)->ss.ss_family == AF_INET) { \

53
src/wtp/wtp.c
View File

@ -75,8 +75,8 @@ static int wtp_init(void) {
/* AC information */ /* AC information */
g_wtp.discoverytype.type = CAPWAP_DISCOVERYTYPE_TYPE_UNKNOWN; g_wtp.discoverytype.type = CAPWAP_DISCOVERYTYPE_TYPE_UNKNOWN;
g_wtp.acdiscoveryrequest = 1; g_wtp.acdiscoveryrequest = 1;
g_wtp.acdiscoveryarray = capwap_array_create(sizeof(union sockaddr_capwap), 0, 0); g_wtp.acdiscoveryarray = capwap_array_create(sizeof(struct addr_capwap), 0, 0);
g_wtp.acpreferedarray = capwap_array_create(sizeof(union sockaddr_capwap), 0, 0); g_wtp.acpreferedarray = capwap_array_create(sizeof(struct addr_capwap), 0, 0);
g_wtp.acdiscoveryresponse = capwap_array_create(sizeof(struct wtp_discovery_response), 0, 1); g_wtp.acdiscoveryresponse = capwap_array_create(sizeof(struct wtp_discovery_response), 0, 1);
/* Radios */ /* Radios */
@ -136,14 +136,15 @@ static void wtp_destroy(void) {
/* */ /* */
static void wtp_add_default_acaddress() { static void wtp_add_default_acaddress() {
union sockaddr_capwap address; struct addr_capwap address;
/* Broadcast IPv4 */ /* Broadcast IPv4 */
memset(&address, 0, sizeof(union sockaddr_capwap)); memset(&address, 0, sizeof(struct addr_capwap));
address.sin.sin_family = AF_INET; address.resolved = 1;
address.sin.sin_addr.s_addr = INADDR_BROADCAST; address.socket.sin.sin_family = AF_INET;
address.sin.sin_port = htons(CAPWAP_CONTROL_PORT); address.socket.sin.sin_addr.s_addr = INADDR_BROADCAST;
memcpy(capwap_array_get_item_pointer(g_wtp.acdiscoveryarray, g_wtp.acdiscoveryarray->count), &address, sizeof(union sockaddr_capwap)); address.socket.sin.sin_port = htons(CAPWAP_CONTROL_PORT);
memcpy(capwap_array_get_item_pointer(g_wtp.acdiscoveryarray, g_wtp.acdiscoveryarray->count), &address, sizeof(struct addr_capwap));
/* Multicast IPv4 */ /* Multicast IPv4 */
/* TODO */ /* TODO */
@ -1068,20 +1069,22 @@ static int wtp_parsing_configuration_1_0(config_t* config) {
for (i = 0; i < count; i++) { for (i = 0; i < count; i++) {
const char* address = config_setting_get_string_elem(configSetting, i); const char* address = config_setting_get_string_elem(configSetting, i);
if (address != NULL) { if (address != NULL) {
union sockaddr_capwap acaddr; struct addr_capwap acaddr;
memset(&acaddr, 0, sizeof(struct addr_capwap));
strncpy(acaddr.fqdn, address, CAPWAP_MAX_FQDN_SIZE-1);
acaddr.resolved = 0;
/* Parsing address */ /* Parsing address */
if (capwap_address_from_string(address, &acaddr)) { if (capwap_address_from_string(address, &acaddr.socket)) {
if (!CAPWAP_GET_NETWORK_PORT(&acaddr)) { if (!CAPWAP_GET_NETWORK_PORT(&acaddr.socket)) {
CAPWAP_SET_NETWORK_PORT(&acaddr, CAPWAP_CONTROL_PORT); CAPWAP_SET_NETWORK_PORT(&acaddr.socket, CAPWAP_CONTROL_PORT);
} }
acaddr.resolved = 1;
memcpy(capwap_array_get_item_pointer(g_wtp.acdiscoveryarray, g_wtp.acdiscoveryarray->count), &acaddr, sizeof(union sockaddr_capwap));
g_wtp.discoverytype.type = CAPWAP_DISCOVERYTYPE_TYPE_STATIC; g_wtp.discoverytype.type = CAPWAP_DISCOVERYTYPE_TYPE_STATIC;
} else { } else {
capwap_logging_error("Invalid configuration file, invalid application.acdiscovery.host value"); capwap_logging_info("%s:%d Could not resolve application.acdiscovery.host %s", __FILE__, __LINE__, address);
return 0;
} }
memcpy(capwap_array_get_item_pointer(g_wtp.acdiscoveryarray, g_wtp.acdiscoveryarray->count), &acaddr, sizeof(struct addr_capwap));
} }
} }
} }
@ -1094,19 +1097,21 @@ static int wtp_parsing_configuration_1_0(config_t* config) {
for (i = 0; i < count; i++) { for (i = 0; i < count; i++) {
const char* address = config_setting_get_string_elem(configSetting, i); const char* address = config_setting_get_string_elem(configSetting, i);
if (address != NULL) { if (address != NULL) {
union sockaddr_capwap acaddr; struct addr_capwap acaddr;
memset(&acaddr, 0, sizeof(struct addr_capwap));
strncpy(acaddr.fqdn, address, CAPWAP_MAX_FQDN_SIZE-1);
acaddr.resolved = 0;
/* Parsing address */ /* Parsing address */
if (capwap_address_from_string(address, &acaddr)) { if (capwap_address_from_string(address, &acaddr.socket)) {
if (!CAPWAP_GET_NETWORK_PORT(&acaddr)) { if (!CAPWAP_GET_NETWORK_PORT(&acaddr.socket)) {
CAPWAP_SET_NETWORK_PORT(&acaddr, CAPWAP_CONTROL_PORT); CAPWAP_SET_NETWORK_PORT(&acaddr.socket, CAPWAP_CONTROL_PORT);
} }
acaddr.resolved = 1;
memcpy(capwap_array_get_item_pointer(g_wtp.acpreferedarray, g_wtp.acpreferedarray->count), &acaddr, sizeof(union sockaddr_capwap));
} else { } else {
capwap_logging_error("Invalid configuration file, invalid application.acprefered.host value"); capwap_logging_info("%s:%d Could not resolve application.acprefered.host %s", __FILE__, __LINE__, acaddr.fqdn);
return 0;
} }
memcpy(capwap_array_get_item_pointer(g_wtp.acpreferedarray, g_wtp.acpreferedarray->count), &acaddr, sizeof(struct addr_capwap));
} }
} }
} }

46
src/wtp/wtp_dfa_discovery.c
View File

@ -49,9 +49,18 @@ void wtp_dfa_state_discovery_timeout(struct capwap_timeout* timeout, unsigned lo
/* Check for preferred AC */ /* Check for preferred AC */
for (j = 0; j < ((indexpreferred != -1) ? indexpreferred : g_wtp.acpreferedarray->count); j++) { for (j = 0; j < ((indexpreferred != -1) ? indexpreferred : g_wtp.acpreferedarray->count); j++) {
union sockaddr_capwap* acpreferredaddr = (union sockaddr_capwap*)capwap_array_get_item_pointer(g_wtp.acpreferedarray, j); struct addr_capwap* acpreferredaddr = (struct addr_capwap*)capwap_array_get_item_pointer(g_wtp.acpreferedarray, j);
if (!acpreferredaddr->resolved) {
if (!capwap_compare_ip(acpreferredaddr, &checkaddr)) { if (capwap_address_from_string(acpreferredaddr->fqdn, &acpreferredaddr->socket)) {
if (!CAPWAP_GET_NETWORK_PORT(&acpreferredaddr->socket)) {
CAPWAP_SET_NETWORK_PORT(&acpreferredaddr->socket, CAPWAP_CONTROL_PORT);
}
acpreferredaddr->resolved = 1;
} else {
capwap_logging_info("%s:%d Could not resolve application.acprefered.host %s", __FILE__, __LINE__, acpreferredaddr->fqdn);
}
}
if (!capwap_compare_ip(&acpreferredaddr->socket, &checkaddr)) {
indexpreferred = j; indexpreferred = j;
memcpy(&peeraddr, &checkaddr, sizeof(union sockaddr_capwap)); memcpy(&peeraddr, &checkaddr, sizeof(union sockaddr_capwap));
break; break;
@ -79,9 +88,18 @@ void wtp_dfa_state_discovery_timeout(struct capwap_timeout* timeout, unsigned lo
/* Check for preferred AC */ /* Check for preferred AC */
for (j = 0; j < ((indexpreferred != -1) ? indexpreferred : g_wtp.acpreferedarray->count); j++) { for (j = 0; j < ((indexpreferred != -1) ? indexpreferred : g_wtp.acpreferedarray->count); j++) {
union sockaddr_capwap* acpreferredaddr = (union sockaddr_capwap*)capwap_array_get_item_pointer(g_wtp.acpreferedarray, j); struct addr_capwap* acpreferredaddr = (struct addr_capwap*)capwap_array_get_item_pointer(g_wtp.acpreferedarray, j);
if (!acpreferredaddr->resolved) {
if (!capwap_compare_ip(acpreferredaddr, &checkaddr)) { if (capwap_address_from_string(acpreferredaddr->fqdn, &acpreferredaddr->socket)) {
if (!CAPWAP_GET_NETWORK_PORT(&acpreferredaddr->socket)) {
CAPWAP_SET_NETWORK_PORT(&acpreferredaddr->socket, CAPWAP_CONTROL_PORT);
}
acpreferredaddr->resolved = 1;
} else {
capwap_logging_info("Could not resolve application.acprefered.host %s", acpreferredaddr->fqdn);
}
}
if (!capwap_compare_ip(&acpreferredaddr->socket, &checkaddr)) {
indexpreferred = j; indexpreferred = j;
memcpy(&peeraddr, &checkaddr, sizeof(union sockaddr_capwap)); memcpy(&peeraddr, &checkaddr, sizeof(union sockaddr_capwap));
break; break;
@ -183,8 +201,20 @@ void wtp_dfa_state_discovery_timeout(struct capwap_timeout* timeout, unsigned lo
/* Send discovery request to AC */ /* Send discovery request to AC */
for (i = 0; i < g_wtp.acdiscoveryarray->count; i++) { for (i = 0; i < g_wtp.acdiscoveryarray->count; i++) {
if (!capwap_sendto_fragmentpacket(g_wtp.net.socket, g_wtp.requestfragmentpacket, (union sockaddr_capwap*)capwap_array_get_item_pointer(g_wtp.acdiscoveryarray, i))) { struct addr_capwap* addr = capwap_array_get_item_pointer(g_wtp.acdiscoveryarray, i);
capwap_logging_debug("Warning: error to send discovery request packet"); if (!addr->resolved) {
if (capwap_address_from_string(addr->fqdn, &addr->socket)) {
if (!CAPWAP_GET_NETWORK_PORT(&addr->socket)) {
CAPWAP_SET_NETWORK_PORT(&addr->socket, CAPWAP_CONTROL_PORT);
}
addr->resolved = 1;
g_wtp.discoverytype.type = CAPWAP_DISCOVERYTYPE_TYPE_STATIC;
} else {
capwap_logging_info("%s:%d Could not resolve application.acdiscovery.host %s", __FILE__, __LINE__, addr->fqdn);
}
}
if (!capwap_sendto_fragmentpacket(g_wtp.net.socket, g_wtp.requestfragmentpacket, &addr->socket)) {
capwap_logging_info("Error to send discovery request packet");
} }
} }

20
src/wtp/wtp_dfa_idle.c
View File

@ -12,11 +12,12 @@ static int wtp_join_prefered_ac()
while (g_wtp.acpreferedselected < g_wtp.acpreferedarray->count) while (g_wtp.acpreferedselected < g_wtp.acpreferedarray->count)
{ {
union sockaddr_capwap localaddr; union sockaddr_capwap localaddr;
union sockaddr_capwap *peeraddr; struct addr_capwap *peeraddr;
/* Found in configuration file the AC address */ /* Found in configuration file the AC address */
peeraddr = capwap_array_get_item_pointer(g_wtp.acpreferedarray, peeraddr = capwap_array_get_item_pointer(g_wtp.acpreferedarray,
g_wtp.acpreferedselected); g_wtp.acpreferedselected);
/* Next AC */ /* Next AC */
g_wtp.acpreferedselected++; g_wtp.acpreferedselected++;
@ -28,7 +29,18 @@ static int wtp_join_prefered_ac()
return -1; return -1;
} }
if (capwap_connect_socket(&g_wtp.net, peeraddr) < 0) { if(!peeraddr->resolved) {
if (capwap_address_from_string(peeraddr->fqdn, &peeraddr->socket)) {
if (!CAPWAP_GET_NETWORK_PORT(&peeraddr->socket)) {
CAPWAP_SET_NETWORK_PORT(&peeraddr->socket, CAPWAP_CONTROL_PORT);
}
peeraddr->resolved = 1;
} else {
capwap_logging_info("%s:%d Could not resolve application.acprefered.host %s", __FILE__, __LINE__, peeraddr->fqdn);
}
}
if (capwap_connect_socket(&g_wtp.net, &peeraddr->socket) < 0) {
capwap_logging_fatal("Cannot bind control address"); capwap_logging_fatal("Cannot bind control address");
capwap_close_sockets(&g_wtp.net); capwap_close_sockets(&g_wtp.net);
return -1; return -1;
@ -42,7 +54,7 @@ static int wtp_join_prefered_ac()
} }
/* */ /* */
capwap_crypt_setconnection(&g_wtp.dtls, g_wtp.net.socket, &localaddr, peeraddr); capwap_crypt_setconnection(&g_wtp.dtls, g_wtp.net.socket, &localaddr, &peeraddr->socket);
/* */ /* */
if (!g_wtp.enabledtls) { if (!g_wtp.enabledtls) {